Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sqlite datatypes #582

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Conversation

MarkZither
Copy link
Contributor

@MarkZither MarkZither commented Nov 7, 2021

Fix for #578
Changed all DECIMAL columns to REAL to avoid an issue with dynamic datatypes in sqlite as discussed in https://stackoverflow.com/questions/39980840/sqlite-using-dapper-error-parsing-column-unable-to-cast-object-of-type-system

@DrLeh
Copy link

DrLeh commented Oct 11, 2022

I cloned the source code of this storage to my project with this change in it and it worked fine.

@MarkZither MarkZither changed the title [WIP] Fix/sqlite datatypes Fix/sqlite datatypes Dec 19, 2022
Copy link
Member

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get to this until now - getting in for the 4.3 release, thank you!

@NickCraver NickCraver merged commit 85f8f76 into MiniProfiler:main Feb 9, 2023
@MarkZither MarkZither deleted the fix/sqlite_datatypes branch March 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants