Precompile doT.js templates #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 21 21
Lines 1247 1247
=======================================
Hits 1101 1101
Misses 146 146
Continue to review full report at Codecov.
|
jorgemanrubia
approved these changes
Oct 26, 2019
There was a problem hiding this comment.
@OsamaSayegh thanks for taking care of this 🙏🙏. I can confirm rack-mini-profiler now works without unsafe-eval in the CSP. Wonderful addition! Also great to move pretty-print.js outside of the main JS source 👍.
|
Awesome change ... going to push out another release now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a build step that pre-compiles our doT.js templates. This is needed because doT.js uses
evalwhich prevents us from disallowingunsafe-evalin CSP.