Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9.4] Profile command shows no results. #50

Closed
LuxusDarkangel opened this issue Jul 5, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@LuxusDarkangel
Copy link

commented Jul 5, 2016

Log: https://gist.github.com/LuxusDarkangel/0273e8faf7b2a89811533ad6d7c20563

Happens in pure Forge and using SpongeForge.

@nallar

This comment has been minimized.

Copy link
Member

commented Jul 5, 2016

Working fine here. About 90% sure it's because you tested with no users online and waited a while before testing.

Entities stop getting ticked after 1200 ticks if no-one's online and there are no forced chunks.

@LuxusDarkangel

This comment has been minimized.

Copy link
Author

commented Jul 5, 2016

In this case you're totally right, but the issue is still there. I tested it first in-game using SpongeForge, and then proceeded to test it in a pure Forge server using only the console, as shown in the log, to make sure it wasn't a Sponge issue. It is, If you install latest SpongeForge version for 1.9.4, it doesn't display profiling results even while being in-game and making sure entities are getting ticked.

@nallar nallar added bug and removed needs user input labels Jul 5, 2016

nallar added a commit that referenced this issue Jul 5, 2016

@nallar nallar added the Sponge label Jul 5, 2016

@nallar

This comment has been minimized.

Copy link
Member

commented Jul 5, 2016

So it's working fine with just forge, only an issue with sponge? I made a silly commit just then which probably doesn't actually fix it. Looks like some sort of mappings issue:

With Sponge:

[23:33:13] [main/TRACE] [JavaPatcher/]: Patching net.minecraft.world.WorldServer with clone(deobf:net.minecraft.world.WorldServer/updateEntities,to:updateEntities_withProfiling) {func_72939_s()V}
[23:33:13] [main/TRACE] [JavaPatcher/]: Patching net.minecraft.world.WorldServer with insertCodeBefore(deobf:net.minecraft.world.WorldServer/updateEntities) {func_72939_s()V}
[23:33:13] [main/TRACE] [JavaPatcher/]: Patching net.minecraft.world.WorldServer with replaceMethodCall(deobf:net.minecraft.world.WorldServer/updateEntities_withProfiling,method:func_73660_a) {updateEntities_withProfiling()}
[23:33:13] [main/WARN] [JavaPatcher/]: Didn't find any method calls to replace in net.minecraft.world.WorldServer.updateEntities_withProfiling(). Class: null, method: func_73660_a, index: -1
[23:33:13] [main/TRACE] [JavaPatcher/]: Patching net.minecraft.world.WorldServer with replaceMethodCall(deobf:net.minecraft.world.WorldServer/updateEntities_withProfiling,method:func_72870_g) {updateEntities_withProfiling()}
[23:33:13] [main/WARN] [JavaPatcher/]: Didn't find any method calls to replace in net.minecraft.world.WorldServer.updateEntities_withProfiling(). Class: null, method: func_72870_g, index: -1

Going to sleep now, need to get up early tomorrow so staying up to fix this is a bad idea.

@LuxusDarkangel

This comment has been minimized.

Copy link
Author

commented Jul 5, 2016

Yeah, it's not fixed yet. We'll see tomorrow then.

@nallar

This comment has been minimized.

Copy link
Member

commented Jul 6, 2016

Sponge patching of updateEntities has changed to https://github.com/SpongePowered/SpongeCommon/blob/1.9.4/src/main/java/org/spongepowered/common/mixin/core/world/MixinWorld.java#L812

May be able to fix this by removing the sponge-specific patch. Unexpected, but nice.

nallar added a commit that referenced this issue Jul 6, 2016

@nallar

This comment has been minimized.

Copy link
Member

commented Jul 6, 2016

Can you confirm if that fix worked in 1.9.4 build 4?

edit: Marking as 1.10 as this change will also apply to future sponge releases on 1.10.

@nallar nallar added the 1.10.2 label Jul 6, 2016

@LuxusDarkangel

This comment has been minimized.

Copy link
Author

commented Jul 6, 2016

Yes, it worked.

Guess the same issue will happen with 1.10, but I don't have time to test it right now, will do later.

@nallar

This comment has been minimized.

Copy link
Member

commented Jul 7, 2016

Thanks, fix also in 1.10 branch now.

@nallar nallar closed this Jul 7, 2016

@nallar nallar removed the needs user input label Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.