Support I64 token mappings in safetensors model loading#41
Merged
Conversation
Member
|
@maxprogrammer007 thanks for fixing this. There was a small formatting issue which caused CI to fail, I've fixed it on your branch. Will release this soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes model loading for vocab-quantized models whose
mappingtensor is stored asI64in the safetensors header. The loader previously assumed all mappings were 32-bit integers and decoded the raw bytes withchunks_exact(4), which produced incorrect token ID mappings for models likepotion-code-16M.Changes
mappingbased ont.dtype()instead of assumingI32I32andI64mappingsI32andI64decodingValidation
cargo test decode_token_mapping --libcargo test quantized_models_match_float32fixes #40