fix(deps): replace abandoned docxtemplater-image-module-free with docxtemplater-image#18
Merged
Conversation
…xtemplater-image Removes the critical xmldom advisory (GHSA-crh6-fp67-6883, CVSS 9.8) by replacing the abandoned docxtemplater-image-module-free@1.1.1 — which pinned the deprecated xmldom@0.1.x — with maintained docxtemplater-image@0.1.2, which uses @xmldom/xmldom@^0.9.7 (the same line as core docxtemplater@3.68). npm audit: 4 vulns (1 critical, 3 moderate) -> 2 moderate. The remaining 2 are postcss-in-next, unrelated and unfixable until Next 16.3 stable. API is identical: same getImage/getSize/centered options and {%token} placeholder syntax. No behavioral change to the Address Labels mail-merge feature; the upload-your-own-template flow continues to work unchanged. Verification: - npm run test:run: 45 files, 667 tests pass - npm run lint: clean - npm run build: clean Manual end-to-end browser test recommended before release (sample template upload -> merge -> open in Word -> verify barcode image rendering). Closes the xmldom-critical-vulnerability TODO. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docxtemplater-image-module-free@1.1.1(depends on deprecatedxmldom@0.1.x) with maintaineddocxtemplater-image@0.1.2(uses@xmldom/xmldom@^0.9.7, same line as coredocxtemplater@3.68).npm audit.getImage/getSize/centeredoptions +{%token}placeholder syntax), so this is a drop-in for the Address Labels Mail Merge feature — no behavioral changes.npm audit: 4 vulns (1 critical, 3 moderate) → 2 moderate. The remaining two are an unrelated postcss-in-next pin that won't be fixable until Next 16.3 stable.Changes
package.json: dep swapsrc/components/address-labels/actions.ts: import pathsrc/components/address-labels/actions.test.ts:vi.mocktargetsrc/components/address-labels/sample-template.ts: comment-onlysrc/types/docxtemplater-image.d.ts: renamed shim.claude/references/components/address-labels.md: dep mention.claude/TODO/: closedxmldom-critical-vulnerabilityTODO + INDEXTest plan
npm run test:run— 45 files, 667 tests passnpm run lint— cleannpm run build— cleannpm audit— critical xmldom cleared{#AddressLine2}and{#isNotLast}conditionals behave correctly🤖 Generated with Claude Code