Update _core.py

[mgaertne]

added an exception hook for threads forwarding the relevant parameters to minqlx.handle_exception in order to have errors from threads logged in the logfile as well.

[em92]

Hi, Markus!
Using this plugin:

import minqlx
from time import sleep


class test(minqlx.Plugin):
    def __init__(self):
        self.add_hook("new_game", self.handle_new_game)

    def handle_new_game(self):
        @minqlx.delay(2)
        def f():
            raise NotImplementedError("test")

        f()

Info about exception appears in logfile without patch in this PR. What is your use-case?

Also, could you please remove those whitespaces? That are marked as red?

[mgaertne]

Heya, the use case would be @minqlx.thread, not @minqlx.delay. Right now, exceptions happening in a thread are not logged, and I had several occasions where an exception was happening in a thread that went unnoticed while play testing, only to realize the problem later after many back and forths, finally taking out the @minqlx.thread, and seeing the problem only then in the logfiles. Let me check on those whitespaces. Best Markus

…

On Sat, Apr 23, 2022 at 8:04 AM Eugene Molotov ***@***.***> wrote: Hi, Markus! Using this plugin: import minqlx from time import sleep class test(minqlx.Plugin): def __init__(self): self.add_hook("new_game", self.handle_new_game) def handle_new_game(self): @minqlx.delay(2) def f(): raise NotImplementedError("test") f() Info about exception appears in logfile without patch in this PR. What is your use-case? Also, could you please remove those whitespaces? That are marked as red? [image: Снимок экрана_2022-04-23_10-50-26] <https://user-images.githubusercontent.com/15870400/164882255-fcca38af-b90a-40d3-ba80-00f557355ee0.png> — Reply to this email directly, view it on GitHub <#110 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALXQC5DMICFLZPKTDBJJDVGOHHDANCNFSM5UCW5GMA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mgaertne]

To reproduce use the following plugin:

import minqlx


class exception_thread(minqlx.Plugin):
    def __init__(self):
        super().__init__()

        self.add_command("exception_thread", self.cmd_exception_thread)

    def cmd_exception_thread(self, _player: minqlx.Player, _cmd: str, _channel: minqlx.AbstractChannel):
        @minqlx.thread
        def throws_exception():
            self.logger.debug("about to throw exception in thread...")
            raise NotImplementedError("Test")

        self.logger.debug("about to start exception thread...")
        throws_exception()
        self.logger.debug("exception thread started...")

output before updating _core.py:

(19:31:22) [DEBUG @ minqlx.exception_thread.cmd_exception_thread] about to start exception thread...
(19:31:22) [DEBUG @ minqlx.exception_thread.throws_exception] about to throw exception in thread...
(19:31:22) [DEBUG @ minqlx.exception_thread.cmd_exception_thread] exception thread started...

output after updating _core.py:

(19:36:04) [DEBUG @ minqlx.exception_thread.cmd_exception_thread] about to start exception thread...
(19:36:04) [DEBUG @ minqlx.exception_thread.throws_exception] about to throw exception in thread...
(19:36:04) [DEBUG @ minqlx.exception_thread.cmd_exception_thread] exception thread started...
(19:36:04) [ERROR @ minqlx.handle_exception] Traceback (most recent call last):
(19:36:04) [ERROR @ minqlx.handle_exception]   File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner
(19:36:04) [ERROR @ minqlx.handle_exception]     self.run()
(19:36:04) [ERROR @ minqlx.handle_exception]   File "/usr/lib/python3.9/threading.py", line 892, in run
(19:36:04) [ERROR @ minqlx.handle_exception]     self._target(*self._args, **self._kwargs)
(19:36:04) [ERROR @ minqlx.handle_exception]   File "./minqlx-plugins/exception_thread.py", line 14, in throws_exception
(19:36:04) [ERROR @ minqlx.handle_exception]     raise NotImplementedError("Test")
(19:36:04) [ERROR @ minqlx.handle_exception] NotImplementedError: Test