Update python_embed.c#116
Merged
Merged
Conversation
fixed two things that changed with python version 3.7: - PyUnicode_AsUTF8 now returns a const char* rather than just a char* - PyEval_InitThreads() does nothing, since it's now called in Py_Initialize(), and will be removed with python version 3.11
em92
reviewed
Mar 19, 2023
| static PyObject* PyMinqlx_ReplaceItems(PyObject* self, PyObject* args) { | ||
| PyObject *arg1, *arg2 ; | ||
| int entity_id = 0, item_id = 0; | ||
| #if PY_MINOR_VERSION < 7 |
Collaborator
There was a problem hiding this comment.
True statement for Python 3.5, 3.6, 4.0, 4.1 .. 4.6.
Suggesting to use PY_VERSION_HEX
em92
reviewed
Mar 19, 2023
Comment on lines
+1922
to
+1924
| #if PY_MINOR_VERSION < 7 | ||
| PyEval_InitThreads(); | ||
| #endif |
Collaborator
There was a problem hiding this comment.
changed to using PY_VERSION_HEX. Hope it's self-explanatory enough
Collaborator
|
Hi, Markus! Recently pushed github workflow for automatic testing, if minqlx does compile. Could you please rebase your branch on newest master? |
Contributor
Author
|
Done. The github actions did not trigger, though, unfortunately. :/ |
Collaborator
I think you forgot to push commits |
Contributor
Author
|
Now I think it worked. |
Collaborator
|
I thought I merged it long time ago. :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed two things that changed with python version 3.7: