From f97ad58939d0e28bab60295a6f582dfc08d5889e Mon Sep 17 00:00:00 2001
From: Till <31419678+tifrel@users.noreply.github.com>
Date: Wed, 7 Aug 2024 11:40:01 +0200
Subject: [PATCH] fix(wallet): Encode nonces as base64 on redirect (#530)

---
 packages/wallet/src/bitte-wallet.ts    | 4 ++--
 packages/wallet/src/mintbase-wallet.ts | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/wallet/src/bitte-wallet.ts b/packages/wallet/src/bitte-wallet.ts
index d5171de9..244ab73f 100644
--- a/packages/wallet/src/bitte-wallet.ts
+++ b/packages/wallet/src/bitte-wallet.ts
@@ -217,7 +217,7 @@ export const BitteWallet: WalletBehaviourFactory<
 
     const newUrl = new URL(`${metadata.walletUrl}/sign-message`);
     newUrl.searchParams.set('message', message);
-    newUrl.searchParams.set('nonce', nonce);
+    newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64'));
     newUrl.searchParams.set('recipient', recipient);
     newUrl.searchParams.set('callbackUrl', cbUrl);
     window.location.assign(newUrl.toString());
@@ -230,7 +230,7 @@ export const BitteWallet: WalletBehaviourFactory<
     newUrl.searchParams.set('accountId', accountId);
     newUrl.searchParams.set('publicKey', publicKey);
     newUrl.searchParams.set('signature', signature);
-    newUrl.searchParams.set('nonce', nonce);
+    newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64'));
     newUrl.searchParams.set('recipient', recipient);
     newUrl.searchParams.set('callbackUrl', callbackUrl);
 
diff --git a/packages/wallet/src/mintbase-wallet.ts b/packages/wallet/src/mintbase-wallet.ts
index 5874c1cd..1fa89212 100644
--- a/packages/wallet/src/mintbase-wallet.ts
+++ b/packages/wallet/src/mintbase-wallet.ts
@@ -217,7 +217,7 @@ export const MintbaseWallet: WalletBehaviourFactory<
 
     const newUrl = new URL(`${metadata.walletUrl}/sign-message`);
     newUrl.searchParams.set('message', message);
-    newUrl.searchParams.set('nonce', nonce);
+    newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64'));
     newUrl.searchParams.set('recipient', recipient);
     newUrl.searchParams.set('callbackUrl', cbUrl);
     window.location.assign(newUrl.toString());
@@ -230,7 +230,7 @@ export const MintbaseWallet: WalletBehaviourFactory<
     newUrl.searchParams.set('accountId', accountId);
     newUrl.searchParams.set('publicKey', publicKey);
     newUrl.searchParams.set('signature', signature);
-    newUrl.searchParams.set('nonce', nonce);
+    newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64'));
     newUrl.searchParams.set('recipient', recipient);
     newUrl.searchParams.set('callbackUrl', callbackUrl);