New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectInputs & GetBlocksToMaturity do not look for the same amount of confs #15

Open
presstab opened this Issue Aug 4, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@presstab
Contributor

presstab commented Aug 4, 2015

40 confirmations is the number required by connectinputs, which is where this is actually checked by other nodes when a block comes in. Now that I look at this, it is a bit unusual that this never matched up with GetBlocksToMaturity() which is coded to ask for ten more than that (both before and after the fork). When I made the fork code to change the confirmations required, I kept the logic in all areas the same, but added an extra 10 to each.

This seems to be uniform over a large amount of coins and not specific to MINT

@shane-kerr shane-kerr added the bug label Mar 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment