Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security Policy #1505

Merged
merged 4 commits into from Jun 4, 2021
Merged

Add Security Policy #1505

merged 4 commits into from Jun 4, 2021

Conversation

tcbutler320
Copy link
Contributor

Description

This pull request adds a security policy to MonkeyType in order to better facilitate responsible vulnerability disclosures, moving them out of GitHub issues and into email/discord. Included in the policy is a /security-policy.html page with footer link, as well as a security policy in /.well-known/security.txt. Security.txt is an Internet Draft that has been submitted for RFC review, it's stated mission:

“When security risks in web services are discovered by independent security researchers who understand the severity of the risk, they often lack the channels to disclose them properly. As a result, security issues may be left unreported. security.txt defines a standard to help organizations define the process for security researchers to disclose security vulnerabilities securely.”

Key Changes

  • Added /static/security-policy.html, which is essentially a copy of privacy-policy.html with security policy language
  • Added /static/.well-known/security.txt which includes a template created with securitytxt.org
  • Added the dot:true argument to gulpfile in order to copy ./well-known/* to dist
  • Added fontawesome icon to footer, linking to security-policy.html

/security-policy

security_policy

/.well-known/security.txt

security txt

/

Changes in footer

home.

Checklist

  • I have read the CODE_OF_CONDUCT.md and the CONTRIBUTING.md
  • I checked if my PR has any bugs or other issues that could reduce the stability of the project
  • I understand that the maintainer has the right to reject my contribution and it may not get accepted.

Resolves feature request in discussion #1485.
Related to #1476 #1498 #1503 #1348

@tcbutler320
Copy link
Contributor Author

tcbutler320 commented Jun 4, 2021

This is nit-picky but i'm just seeing the question mark in "How to Disclose a Vulnerability", maybe that should be removed

@Miodec
Copy link
Member

Miodec commented Jun 4, 2021

This is nit-picky but i'm just seeing the question mark in "How to Disclose a Vulnerability", maybe that should be removed

Agreed

@Miodec Miodec merged commit 92b1c6e into monkeytypegame:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants