Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glmark2-es2 --fullscreen on XWayland is not fullscreen #1669

Closed
Saviq opened this issue Aug 11, 2020 · 2 comments · Fixed by #1670
Closed

glmark2-es2 --fullscreen on XWayland is not fullscreen #1669

Saviq opened this issue Aug 11, 2020 · 2 comments · Fixed by #1670
Labels

Comments

@Saviq
Copy link
Collaborator

Saviq commented Aug 11, 2020

One way to reproduce:

mir_performance_tests --gtest_filter=GLMark2Xwayland.fullscreen

There should be no decoration afaict?

@wmww wmww added the XWayland label Aug 11, 2020
@wmww
Copy link
Contributor

wmww commented Aug 11, 2020

Odd. Fullscreen works fine on all other XWayland apps tested (Gedit, Kate and Blender). Stranger still glmark2-es2 --fullscreen seems to be intermittently fullscreen on sway (about one every ten runs it's windowed). Will investigate.

@wmww wmww changed the title XWayland fullscreen looks maximized rather than fullscreen glmark2-es2 --fullscreen on XWayland is not fullscreen Aug 11, 2020
@wmww
Copy link
Contributor

wmww commented Aug 11, 2020

Ah! it's setting _NET_WM_STATE before mapping the window. We were ignoring that because X11 apps are supposed to use a client message to change that property, but according to the protocol apps can set it initially and the window manager should respect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants