Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
add-tarball-release-tool #36
Conversation
RAOF
and others
added some commits
Nov 15, 2017
AlanGriffiths
requested a review
from
RAOF
Nov 16, 2017
| +VERSION_MINOR=$(grep set.MIR_VERSION_MINOR CMakeLists.txt | cut -f2 -d' ' | tr -d \)) | ||
| +VERSION_PATCH=$(grep set.MIR_VERSION_PATCH CMakeLists.txt | cut -f2 -d' ' | tr -d \)) | ||
| + | ||
| +VERSIONED_NAME=mir-$VERSION_MAJOR.$VERSION_MINOR.$VERSION_PATCH |
RAOF
Nov 17, 2017
Member
We could, if we're going to guarantee that the release tags are there at the right time :)
AlanGriffiths
Nov 17, 2017
Contributor
For building tarballs to upload to the staging PPA we likely want to take the version from CMakeLists.txt.
Also, the guarantee doesn't (yet) hold:
$ git describe --tags
v0.27.0-614-g8f4e0403c8
Saviq
Nov 17, 2017
Owner
Well, the version from CMakeLists.txt is not enough, since there's code on top of it.
Anyway, let's discuss on the forums (will post soon).
| +git archive --format=tar -o $SCRATCH_DIR/$VERSIONED_NAME-wlcs.tar --prefix=$VERSIONED_NAME/tests/acceptance-tests/wayland/wlcs/ HEAD | ||
| +popd | ||
| +git archive --format=tar -o $SCRATCH_DIR/$VERSIONED_NAME.tar --prefix=$VERSIONED_NAME/ HEAD | ||
| +tar --concatenate -vf $SCRATCH_DIR/$VERSIONED_NAME.tar $SCRATCH_DIR/$VERSIONED_NAME-wlcs.tar |
Saviq
Nov 16, 2017
Owner
Could this be a loop on the output from git submodule, so we don't have to do it again when we add a new submodule?
| +make -C $BUILD_DIR install DESTDIR=$INSTALL_DIR | ||
| + | ||
| +mv $SCRATCH_DIR/$VERSIONED_NAME.tar.xz . | ||
| +echo "$VERSIONED_NAME.tar.xz successfully created and tested" |
Saviq
Nov 16, 2017
Owner
Could everything after the release tarball be optional? Or a separate script?
RAOF
Nov 17, 2017
Member
It could be, but I expect we're only going to be running this script a handful of times a month. Why would you want to run it without testing that the tarball is actually buildable and installable?
Saviq
Nov 17, 2017
•
Edited 1 time
-
Saviq
Nov 17, 2017
Owner
-
Nov 17, 2017
So I could use it to build tarballs to upload to the staging PPA ;)
| + | ||
| +echo "Generating Mir tarball…" | ||
| +git archive --format=tar -o $SCRATCH_DIR/$VERSIONED_NAME.tar --prefix=$VERSIONED_NAME/ HEAD | ||
| +for submodule in $(git submodule | cut -f 3 -d ' ') |
RAOF
Nov 17, 2017
Member
I think you mean $(git submodule | cut -f 2 -d ' ')? At least in my working tree the third field is (heads/master).
| +make -C $BUILD_DIR install DESTDIR=$INSTALL_DIR | ||
| + | ||
| +mv $SCRATCH_DIR/$VERSIONED_NAME.tar.xz . | ||
| +echo "$VERSIONED_NAME.tar.xz successfully created and tested" |
Saviq
Nov 16, 2017
Owner
Could everything after the release tarball be optional? Or a separate script?
RAOF
Nov 17, 2017
Member
It could be, but I expect we're only going to be running this script a handful of times a month. Why would you want to run it without testing that the tarball is actually buildable and installable?
Saviq
Nov 17, 2017
•
Edited 1 time
-
Saviq
Nov 17, 2017
Owner
-
Nov 17, 2017
So I could use it to build tarballs to upload to the staging PPA ;)
All checks have passed
| +VERSION_MINOR=$(grep set.MIR_VERSION_MINOR CMakeLists.txt | cut -f2 -d' ' | tr -d \)) | ||
| +VERSION_PATCH=$(grep set.MIR_VERSION_PATCH CMakeLists.txt | cut -f2 -d' ' | tr -d \)) | ||
| + | ||
| +VERSIONED_NAME=mir-$VERSION_MAJOR.$VERSION_MINOR.$VERSION_PATCH |
RAOF
Nov 17, 2017
Member
We could, if we're going to guarantee that the release tags are there at the right time :)
AlanGriffiths
Nov 17, 2017
Contributor
For building tarballs to upload to the staging PPA we likely want to take the version from CMakeLists.txt.
Also, the guarantee doesn't (yet) hold:
$ git describe --tags
v0.27.0-614-g8f4e0403c8
Saviq
Nov 17, 2017
Owner
Well, the version from CMakeLists.txt is not enough, since there's code on top of it.
Anyway, let's discuss on the forums (will post soon).
bot
pushed a commit
that referenced
this pull request
Nov 21, 2017
All checks have passed
bors
bot
commented
Nov 21, 2017
Build succeeded |
AlanGriffiths commentedNov 15, 2017
No description provided.