New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miral/eglapp: Accept EGL versions ≥ 1.4 #665

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@RAOF
Copy link
Member

RAOF commented Dec 10, 2018

There's no need to reject EGL 1.5 here.

Since the NVIDIA driver now supports 1.5, this causes the spinner
to bail on startup on the eglstream-kms platform. (Fixes #661)

miral/eglapp: Accept EGL versions ≥ 1.4
There's no need to reject EGL 1.5 here.

Since the NVIDIA driver now supports 1.5, this causes the spinner
to bail on startup on the eglstream-kms platform. (Fixes #661)
@gerboland
Copy link
Contributor

gerboland left a comment

Yep, worked for me last night

@gerboland

This comment has been minimized.

Copy link
Contributor

gerboland commented Dec 11, 2018

bors r+

bors bot added a commit that referenced this pull request Dec 11, 2018

Merge #665
665: miral/eglapp: Accept EGL versions ≥ 1.4 r=gerboland a=RAOF

There's no need to reject EGL 1.5 here.

Since the NVIDIA driver now supports 1.5, this causes the spinner
to bail on startup on the eglstream-kms platform. (Fixes #661)

Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 11, 2018

@bors bors bot merged commit ec6f038 into master Dec 11, 2018

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bors bors bot deleted the fix-internal-clients-on-nvidia branch Dec 11, 2018

AlanGriffiths added a commit that referenced this pull request Dec 14, 2018

Merge #665
665: miral/eglapp: Accept EGL versions ≥ 1.4 r=gerboland a=RAOF

There's no need to reject EGL 1.5 here.

Since the NVIDIA driver now supports 1.5, this causes the spinner
to bail on startup on the eglstream-kms platform. (Fixes #661)

Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment