From 4d0f0922ea1fec83b2d6b14148c039d6ebf9d024 Mon Sep 17 00:00:00 2001 From: James Frowen Date: Mon, 24 May 2021 03:43:51 +0100 Subject: [PATCH] fix: stopping null ref in disconnect Player should never be null in Peer_OnDisconnected, but adding null check just incase earlier Exception causes player to not be created --- Assets/Mirage/Runtime/NetworkClient.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Assets/Mirage/Runtime/NetworkClient.cs b/Assets/Mirage/Runtime/NetworkClient.cs index 78e64c93e51..df5788b03ba 100644 --- a/Assets/Mirage/Runtime/NetworkClient.cs +++ b/Assets/Mirage/Runtime/NetworkClient.cs @@ -153,7 +153,7 @@ private void Peer_OnConnectionFailed(SocketLayer.IConnection conn, RejectReason private void Peer_OnDisconnected(SocketLayer.IConnection conn, DisconnectReason reason) { if (logger.LogEnabled()) logger.Log($"Disconnected from {conn.EndPoint} with reason {reason}"); - Player.MarkAsDisconnected(); + Player?.MarkAsDisconnected(); // todo add reason to disconnected event // use different enum, so that: // - user doesn't need to add reference to socket layer