Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from goreportcard #856

Merged
merged 1 commit into from Feb 6, 2019
Merged

Fix warnings from goreportcard #856

merged 1 commit into from Feb 6, 2019

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Jan 30, 2019

Cyclomatic complexity warnings not touched. Other warnings fixed skipping part of tests related thingies or naming issues around api constants.


This change is Reviewable

@jellonek jellonek force-pushed the jell/fixgoreportcard branch 4 times, most recently from 3ff4d20 to 8230cb9 Compare February 4, 2019 12:39
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@ivan4th ivan4th merged commit 4ea5dff into master Feb 6, 2019
@ivan4th ivan4th deleted the jell/fixgoreportcard branch February 6, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants