Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CircleCI e2e job based on Debian image #870

Merged
merged 4 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@ivan4th
Copy link
Contributor

ivan4th commented Feb 28, 2019

This PR makes Virtlet and its e2e tests that run on CircleCI compatible with Debian OpenStack images, adds a e2e CircleCI job that uses Debian images, and unblocks the CI by temporarily disabling the multi CNI job.


This change is Reviewable

@lukaszo

lukaszo approved these changes Mar 5, 2019

Copy link
Contributor

lukaszo left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @ivan4th)


pkg/metadata/types/annotations.go, line 124 at r1 (raw file):

	SystemUUID *uuid.UUID
	// ForceDHCPNetworkConfig prevents Virtlet from using Cloud-Init based network
	// configuration and makes it only provide DHCP. Note that this is will

remove is

@ivan4th ivan4th force-pushed the ivan4th/debian-image-ext-e2e branch from 53da665 to 042367c Mar 5, 2019

@ivan4th
Copy link
Contributor Author

ivan4th left a comment

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lukaszo)


pkg/metadata/types/annotations.go, line 124 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

remove is

Done.

@ivan4th ivan4th merged commit 5087718 into master Mar 5, 2019

2 of 4 checks passed

ci/circleci: prepare_build CircleCI is running your tests
Details
codeclimate Code Climate is analyzing this code.
Details
code-review/reviewable 1 of 1 ✓ (lukaszo)
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.