Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use grpc health probe for virtlet #877

Merged
merged 1 commit into from Jun 24, 2019

Conversation

Projects
None yet
5 participants
@sofat1989
Copy link
Contributor

commented Apr 29, 2019

Fix: #863


This change is Reviewable

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 29, 2019

CLA assistant check
All committers have signed the CLA.

@sofat1989 sofat1989 force-pushed the sofat1989:addhealthserver branch 4 times, most recently from e620bf0 to e482cbe Apr 29, 2019

@sofat1989

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

deploy/data changed, please re-run build/cmd.sh update-bindata
Exited with code 1

I had already run this command. And the build is pass in my machine. Can somebody tell me how to fix this?

@sofat1989 sofat1989 force-pushed the sofat1989:addhealthserver branch 4 times, most recently from fba5834 to 84e7f43 Apr 29, 2019

@jellonek
Copy link
Contributor

left a comment

:lgtm:

thx!

Reviewed 9 of 9 files at r1.
Reviewable status: 0 of 1 approvals obtained

@sofat1989 sofat1989 force-pushed the sofat1989:addhealthserver branch 2 times, most recently from 1b8a5bd to 22bb6da May 8, 2019

@keyingliu

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Thanks @sofat1989

use grpc health probe for virtlet container
Signed-off-by: Su Fei <sofat1989@126.com>

@sofat1989 sofat1989 force-pushed the sofat1989:addhealthserver branch from 22bb6da to b76cc75 May 8, 2019

@stale

This comment has been minimized.

Copy link

commented Jun 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 22, 2019

@ivan4th ivan4th removed the wontfix label Jun 24, 2019

@ivan4th
Copy link
Contributor

left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@ivan4th ivan4th merged commit 5a0c02c into Mirantis:master Jun 24, 2019

12 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: e2e_1_12 Your tests passed on CircleCI!
Details
ci/circleci: e2e_calico Your tests passed on CircleCI!
Details
ci/circleci: integration Your tests passed on CircleCI!
Details
ci/circleci: prepare_build Your tests passed on CircleCI!
Details
ci/circleci: push_branch Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
code-review/reviewable 1 of 1 ✓
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.