Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pod recovery after node reboot #895

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@ivan4th
Copy link
Contributor

commented Aug 13, 2019

This change is Reviewable

@stale

This comment has been minimized.

Copy link

commented Sep 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 28, 2019
Copy link
Member

left a comment

LGTM

@stale stale bot removed the wontfix label Sep 30, 2019
@ivan4th ivan4th changed the title [WiP] Fix pod recovery after node reboot Fix pod recovery after node reboot Sep 30, 2019
@ivan4th ivan4th merged commit 9d9dab9 into master Sep 30, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: e2e_1_13 Your tests passed on CircleCI!
Details
ci/circleci: e2e_calico Your tests passed on CircleCI!
Details
ci/circleci: integration Your tests passed on CircleCI!
Details
ci/circleci: prepare_build Your tests passed on CircleCI!
Details
ci/circleci: push_branch Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@lukaszo lukaszo deleted the ivan4th/fix-pod-recovery branch Sep 30, 2019
glog.V(3).Infof("CreateContainer: there's already a container in the sandbox (id: %s)", container.GetID())
//err := v.updateContainer(sandboxInfo, container.GetID())

This comment has been minimized.

Copy link
@jellonek

jellonek Oct 3, 2019

Contributor

Was that intentionally leaved as commented?
IMO that looks like overlooked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.