Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch styling from vanilla CSS to styled-components #2

Closed
davidnmora opened this issue Nov 4, 2021 · 0 comments · Fixed by #6
Closed

Switch styling from vanilla CSS to styled-components #2

davidnmora opened this issue Nov 4, 2021 · 0 comments · Fixed by #6

Comments

@davidnmora
Copy link

davidnmora commented Nov 4, 2021 •
edited

I think this will make implementing dark mode easier, clearer, & more scalable.

It'll also help move your styling into smaller chunks that can live in the same file as the component (this will be really helpful when you've broken down UserDashboard into smaller components with their own files!)
@Mitch4sho Mitch4sho linked a pull request Nov 28, 2021 that will close this issue
user dashboard refactor #6
Merged
Mitch4sho added a commit that referenced this issue Dec 3, 2021
@Mitch4sho
Merge pull request #7 from Mitch4sho/styled-components-refactor
2849ffd 
Styled components refactor resolve #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

user dashboard refactor Mitch4sho/github-user-search-app
1 participant
@davidnmora