Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Plover (Stenography) #47

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Better support for Plover (Stenography) #47

merged 2 commits into from
Oct 5, 2020

Conversation

cominixo
Copy link
Contributor

@cominixo cominixo commented Oct 3, 2020

This PR adds better support to Plover, ignoring spaces at the start of every word, since Plover always adds a space before each word.

Tested with python version - 3.8.5

On operating system - Arch Linux x86_64, kernel 5.8.12-arch1-1

@Mithil467
Copy link
Owner

Can you elaborate this PR's purpose? Also, please create an issue before creating a PR (written in contributing) and read contributing guidelines.

@cominixo
Copy link
Contributor Author

cominixo commented Oct 3, 2020

My bad on not making an issue. Plover is a desktop application for anyone with a supported keyboard to write stenography. When writing a word, Plover always puts a space before a word, and this extra space would make the word show up as incorrect in mitype.

@Mithil467
Copy link
Owner

Yep please create an issue, we will discuss further details there :)

mitype/app.py Show resolved Hide resolved
@Mithil467
Copy link
Owner

Great! Thank you for your contribution! @cominixo 😄

@Mithil467 Mithil467 merged commit 92940a7 into Mithil467:master Oct 5, 2020
@Mithil467 Mithil467 linked an issue Oct 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stenography with Plover will not work with mitype
2 participants