New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"options.state" isn't reflected to history.state #1857

Closed
tanagumo opened this Issue May 24, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@tanagumo
Copy link

tanagumo commented May 24, 2017

Calling m.route.set with options.state within onmatch hook of a RouteResolver, options.state isn't reflected to history.state.

Is it a bug?

@pygy pygy added the bug label May 24, 2017

@pygy

This comment has been minimized.

Copy link
Member

pygy commented May 24, 2017

It is:

if (lastUpdate != null) options = {replace: true}
, thanks for the report

@tanagumo tanagumo changed the title "opitons.state" isn't reflected to history.state "options.state" isn't reflected to history.state May 24, 2017

pygy added a commit to pygy/mithril.js that referenced this issue Jul 5, 2017

@pygy pygy closed this in #1889 Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment