We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Changed in: 632677e#diff-000bdfae56251b0715111d2b18c9de3cR200
From the other changes in that commit, it looks like the line after should use shouldRecycle instead of recycling.
This "bug" causes components to get oninit'ed unnecessarily: see https://jsfiddle.net/3hnjft4u:
I'd gladly make a PR for this.
The text was updated successfully, but these errors were encountered:
Thanks for the report!
At a glance, your analysis seems correct (this example uses a version of Mithril patched according to your suggestion and the problem subsides).
But it's getting late, I'll revisit this tomorrow or on monday (if someone else doesn't beat me to it).
Sorry, something went wrong.
Yup, PR welcome!
render/updateNodes: recycling, clarify terminology, fix logic
fix MithrilJS#2003 partim 1
fix MithrilJS#1992 partim 1
render/updateNodes: call toFragment on the new vnodes, solves issues …
…with actual fragments (fix MithrilJS#1992 partim 2)
recycling => shouldRecycle, Fix MithrilJS#1992 (MithrilJS#1993)
* Fix MithrilJS#1992
* doc in changelog
* add test for MithrilJS#1992
No branches or pull requests