New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ospec] Async stack traces are not displayed properly #2036

Closed
pygy opened this Issue Nov 29, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@pygy
Copy link
Member

pygy commented Nov 29, 2017

in ospec/tests/test-ospec.js change line 42 to read

				o(results.length).equals(22)("Two results")

Expected Behavior

ospec points to the correct assertion line

Current Behavior

1 assertions completed in 222ms, of which 0 failed
reporting > reports per instance:
Two results

2
should equal
22

    at Timer.listOnTimeout (timers.js:270:5)

Possible Solution

not sure yet

Your Environment

  • Version used: ospec@1.4.0
  • Browser Name and version: Node@8.9.1
  • Operating System and version (desktop or mobile): OS X
@pygy

This comment has been minimized.

Copy link
Member

pygy commented Nov 30, 2017

The timeout-related lines are not filtered out of the stack trace by the current regexp. The multi-line error message support caused this regression...

We can easily filter out timers.js: as well for node, but it will be trickier in browsers...

pygy added a commit to pygy/mithril.js that referenced this issue Nov 30, 2017

pygy added a commit to pygy/mithril.js that referenced this issue Nov 30, 2017

pygy added a commit to pygy/mithril.js that referenced this issue Nov 30, 2017

@pygy pygy closed this in b84e093 Nov 30, 2017

pygy added a commit that referenced this issue Nov 30, 2017

pygy added a commit to pygy/mithril.js that referenced this issue Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment