Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached nodes are not handled properly in some branches of the keyed diff algo. #2132

Closed
pygy opened this issue Apr 21, 2018 · 0 comments
Closed

Comments

@pygy
Copy link
Member

@pygy pygy commented Apr 21, 2018

Tests here

When going from [A, B. C, D] to [D, C, B, A] where the vnodes are keyed and reused from one render to the next, they are not moved in the DOM. There's another issue when cached nodes are scrambled, diff isn't actually skipped.

Fix coming soon (tacked to #2130).

pygy added a commit to pygy/mithril.js that referenced this issue Apr 21, 2018
pygy added a commit to pygy/mithril.js that referenced this issue Apr 21, 2018
pygy added a commit to pygy/mithril.js that referenced this issue Apr 21, 2018
pygy added a commit that referenced this issue Apr 23, 2018
@pygy pygy closed this in 801bde2 Apr 23, 2018
isiahmeadows added a commit to isiahmeadows/mithril.js that referenced this issue Oct 12, 2018
isiahmeadows added a commit to isiahmeadows/mithril.js that referenced this issue Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant