Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport all the non-breaking bug fixes from v2 into v1.2 #2243

Closed
2 of 7 tasks
dead-claudia opened this issue Oct 9, 2018 · 1 comment
Closed
2 of 7 tasks

Backport all the non-breaking bug fixes from v2 into v1.2 #2243

dead-claudia opened this issue Oct 9, 2018 · 1 comment
Assignees
Labels
Type: Bug For bugs and any other unexpected breakage
Projects

Comments

@dead-claudia
Copy link
Member

dead-claudia commented Oct 9, 2018

My plan is to backport the non-breaking bug fixes that have made it to next. This will take a while, since I'm factoring in a lot of PRs, and many of them have not applied cleanly.

This may take several days of dedicated, and I've already spent about 3 full days working on this. So it's not an overnight process, and I plan to upload the PR (as WIP) once I've got the renderer changes backported.

Here's my plan + remaining work for v1.2:

  • Fix renderer to retain _state usage and not validate its immutability
  • Make sure all tests pass.
  • Upload a (likely large) PR and get it reviewed and merged. Update: See V1.2 update (WIP) #2247.
  • Release mithril@v1.2.0-rc.
  • Update site to warn against using vnode in closure component outside initial body.
  • Fix any bugs that arise in the process (and port them to v2 as necessary)
  • Release mithril@v1.2.0

(Note to @MithrilJS/collaborators: this will be a little difficult to review piecemeal for render/render.js because I've had so many merge conflicts the history's diffs for it are basically trash. I'm literally redoing that file's backport from the opposite direction now, unbreaking old tests.)

Here's a (possibly incomplete) list of what I plan to include in the backport. (click to show)

Just a PSA: I've been short on time myself or I'd have had this done by now. Those 3 days I spent were about a couple weeks ago or so.

@dead-claudia dead-claudia added Type: Bug For bugs and any other unexpected breakage backport to v1 labels Oct 9, 2018
@dead-claudia dead-claudia added this to the 1.2.0 milestone Oct 9, 2018
@dead-claudia dead-claudia self-assigned this Oct 9, 2018
@dead-claudia dead-claudia added this to High priority in Triage/bugs Oct 28, 2018
@dead-claudia dead-claudia moved this from High priority to Low priority in Triage/bugs Oct 28, 2018
@dead-claudia
Copy link
Member Author

Closing as this is likely to never happen. v2 is barely breaking in most respects, and in the ways it is breaking, it's likely to fix user bugs anyways if it's not codemoddable.

Triage/bugs automation moved this from Low priority to Closed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
Development

No branches or pull requests

1 participant