New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add elem to parent before adding its children #1598

merged 1 commit into from Feb 9, 2017


None yet
4 participants
Copy link

gyandeeps commented Feb 8, 2017

This was done for 0.2.5 but forgotten for 1.0.0 : #1090 (comment)

Here is the previous PR: #1016
Issue comment: #199 (comment)

This should give enough information.

Theme: Add the element to its parent before you add its children to it. this has perf improvements on IE engines (including Edge).

@gyandeeps gyandeeps referenced this pull request Feb 8, 2017


Rewrite Status #1090

19 of 22 tasks complete
Copy link

isiahmeadows left a comment

Single nit, but the rest looks pretty much fine.

@@ -187,7 +187,7 @@ o.spec("oninit", function() {
called = true


This comment has been minimized.


isiahmeadows Feb 8, 2017


Please correct this test instead of just commenting it out.


This comment has been minimized.

Copy link

gyandeeps commented Feb 8, 2017

@isiahmeadows Sorry about that as i actually forgot. Fixed now.

@tivac tivac self-assigned this Feb 8, 2017

@tivac tivac added the enhancement label Feb 8, 2017


This comment has been minimized.

Copy link

tivac commented Feb 8, 2017

I'm going to try and carve out some time to investigate the perf (both generally and for this PR). Thank you so much for re-making this change @gyandeeps and I do apologize again that it got lost in the 0.2 to 1.0 shuffle!

@lhorie lhorie merged commit 2688db8 into MithrilJS:next Feb 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@gyandeeps gyandeeps deleted the gyandeeps:ie-fix branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment