Update: Add elem to parent before adding its children #1598

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
4 participants
@gyandeeps
Contributor

gyandeeps commented Feb 8, 2017

This was done for 0.2.5 but forgotten for 1.0.0 : #1090 (comment)

Here is the previous PR: #1016
Issue comment: #199 (comment)

This should give enough information.

Theme: Add the element to its parent before you add its children to it. this has perf improvements on IE engines (including Edge).

@gyandeeps gyandeeps referenced this pull request Feb 8, 2017

Closed

Rewrite Status #1090

19 of 22 tasks complete
@isiahmeadows

Single nit, but the rest looks pretty much fine.

render/tests/test-oninit.js
@@ -187,7 +187,7 @@ o.spec("oninit", function() {
called = true
o(vnode.dom).equals(undefined)
- o(root.childNodes.length).equals(0)
+ //o(root.childNodes.length).equals(0)

This comment has been minimized.

@isiahmeadows

isiahmeadows Feb 8, 2017

Collaborator

Please correct this test instead of just commenting it out.

@isiahmeadows

isiahmeadows Feb 8, 2017

Collaborator

Please correct this test instead of just commenting it out.

@gyandeeps

This comment has been minimized.

Show comment
Hide comment
@gyandeeps

gyandeeps Feb 8, 2017

Contributor

@isiahmeadows Sorry about that as i actually forgot. Fixed now.

Contributor

gyandeeps commented Feb 8, 2017

@isiahmeadows Sorry about that as i actually forgot. Fixed now.

@tivac tivac self-assigned this Feb 8, 2017

@tivac tivac added the enhancement label Feb 8, 2017

@tivac

This comment has been minimized.

Show comment
Hide comment
@tivac

tivac Feb 8, 2017

Member

I'm going to try and carve out some time to investigate the perf (both generally and for this PR). Thank you so much for re-making this change @gyandeeps and I do apologize again that it got lost in the 0.2 to 1.0 shuffle!

Member

tivac commented Feb 8, 2017

I'm going to try and carve out some time to investigate the perf (both generally and for this PR). Thank you so much for re-making this change @gyandeeps and I do apologize again that it got lost in the 0.2 to 1.0 shuffle!

@lhorie lhorie merged commit 2688db8 into MithrilJS:next Feb 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gyandeeps gyandeeps deleted the gyandeeps:ie-fix branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment