New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in IE11 due to setting of type attribute #1610

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
3 participants
@ytetsuro

ytetsuro commented Feb 9, 2017

If you assign an input type that is not supported by IE11 with an assignment expression, an error will occur.

I confirmed this when I executed the following code.

m('input[type="color"]');
Error in IE11 due to setting of type attribute
If you assign an input type that is not supported by IE11 with an
assignment expression, an error will occur.

@lhorie lhorie merged commit a85f595 into MithrilJS:master Feb 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ytetsuro

This comment has been minimized.

Show comment
Hide comment
@ytetsuro

ytetsuro Feb 9, 2017

thanks merged!!

ytetsuro commented Feb 9, 2017

thanks merged!!

@lhorie

This comment has been minimized.

Show comment
Hide comment
@lhorie

lhorie Feb 9, 2017

Member

Thanks!

Member

lhorie commented Feb 9, 2017

Thanks!

@ytetsuro ytetsuro deleted the ytetsuro:fix-IE11-input-type-error branch Feb 9, 2017

@pygy

This comment has been minimized.

Show comment
Hide comment
@pygy

pygy Feb 21, 2017

Member

@ytetsuro this was targeted against the wrong branch (master)... could you redo this against next? (without building mithril.min.js and mithril.js, Gandalf-the-Bot does that automatically on merge)

Member

pygy commented Feb 21, 2017

@ytetsuro this was targeted against the wrong branch (master)... could you redo this against next? (without building mithril.min.js and mithril.js, Gandalf-the-Bot does that automatically on merge)

lhorie pushed a commit that referenced this pull request Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment