New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override namespace with xmlns attribute #1825

Merged
merged 4 commits into from May 3, 2017

Conversation

Projects
None yet
5 participants
@SamuelTilly
Copy link
Contributor

SamuelTilly commented Apr 29, 2017

Fixes issue #1819 foreignObject inside SVG

Override namespace with xmlns attribute
Fixes issue #1819 foreignObject inside SVG
@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Apr 29, 2017

@tivac @lhorie Any idea why this isn't triggering a Travis run?

@tivac

This comment has been minimized.

Copy link
Member

tivac commented May 1, 2017

Nope, seems real weird though.

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented May 1, 2017

I suspect it's probably a GH webhook issue, or else it'd at least show something here (e.g. an infinitely pending Travis build).

@lhorie

This comment has been minimized.

Copy link
Member

lhorie commented May 1, 2017

yeah, not seeing anything on travis. Can you maybe try to push an empty commit to see if it kicks in again? @SamuelTilly

@SamuelTilly

This comment has been minimized.

Copy link
Contributor

SamuelTilly commented May 1, 2017

looks like it got rejected by travis "abuse detected: known offender (request looked fishy)" https://travis-ci.org/lhorie/mithril.js/requests, looks like it was originally triggered from this " abuse detected: user page on GitHub gives 404 (request looked fishy) " weird.

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented May 1, 2017

@lhorie So I guess you get to contact Travis, then... 😦

@SamuelTilly

This comment has been minimized.

Copy link
Contributor

SamuelTilly commented May 1, 2017

Yeah, got flagged for having an old link on my personal page, never bothered to remove it. contacted the support now.

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented May 1, 2017

@SamuelTilly Could you tell us here once it's resolved?

@SamuelTilly

This comment has been minimized.

Copy link
Contributor

SamuelTilly commented May 1, 2017

@isiahmeadows will do :)

Samuel
@SamuelTilly

This comment has been minimized.

Copy link
Contributor

SamuelTilly commented May 1, 2017

@isiahmeadows @lhorie @tivac, all resolved now, silly commit history tho xD

}

return ns = vnode.attrs && vnode.attrs.xmlns || ns[vnode.tag]

This comment has been minimized.

@pygy

pygy May 1, 2017

Member

return ns = vnode.attrs smells fishy...

Also, you could put the ns object in the parent scope to avoid re-creating it every time getNameSpace() is called.

This comment has been minimized.

@SamuelTilly

SamuelTilly May 2, 2017

Contributor

valid points, i updated the pr :)

@pygy

This comment has been minimized.

Copy link
Member

pygy commented May 1, 2017

Some feedback sent... also, feel free to squash locally and force-push (alternatively, we can also squash the commits from the GH UI when merging).

@pygy

pygy approved these changes May 2, 2017

@isiahmeadows isiahmeadows merged commit de4433c into MithrilJS:next May 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented May 3, 2017

LGTM (hence the merge)

@SamuelTilly SamuelTilly deleted the SamuelTilly:patch-foreignobject branch May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment