New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select option to use empty string value, add tests. #1828

Merged
merged 2 commits into from May 1, 2017

Conversation

Projects
None yet
2 participants
@spacejack
Copy link
Contributor

spacejack commented Apr 30, 2017

This is an attempt to fix: #1814

Adds related tests.

@spacejack

This comment has been minimized.

Copy link
Contributor

spacejack commented Apr 30, 2017

Would be great if someone can check that I'm understanding the old parameter in setAttr correctly.

@isiahmeadows
Copy link
Collaborator

isiahmeadows left a comment

LGTM. And yes, you understood the old parameter correctly (the old attr value).

@isiahmeadows isiahmeadows merged commit 8191f78 into MithrilJS:next May 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment