New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-fix #1595 #1862

Merged
merged 3 commits into from May 31, 2017

Conversation

Projects
None yet
2 participants
@pygy
Copy link
Member

pygy commented May 29, 2017

Some of this will be simplified when we tackle #1804

@isiahmeadows
Copy link
Collaborator

isiahmeadows left a comment

LGTM mod nit - don't see anything glaringly wrong

if (key === "value") {
/*eslint-disable no-implicit-coercion*/
var normalized = "" + value
/*eslint-enable no-implicit-coercion*/

This comment has been minimized.

@isiahmeadows

isiahmeadows May 31, 2017

Collaborator

Could you just use a single // eslint-disable-line no-implicit-coercion here?

Isiah Meadows

@isiahmeadows isiahmeadows merged commit 712be2b into MithrilJS:next May 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment