New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set event.redraw to true before passing it to event handlers, fixes #1850 #1890

Merged
merged 2 commits into from Jul 6, 2017

Conversation

Projects
None yet
1 participant
@pygy
Copy link
Member

pygy commented Jul 5, 2017

No tests for this since the mocks don't implement event bubbling right now.

I suggest we merge this and leave #1850 open with the "needs test case" label only...

@pygy pygy force-pushed the pygy:fix-1850 branch from 75013f3 to 1b7378c Jul 5, 2017

@pygy pygy changed the title Set event.redraw to tru before passing it to event handlers, fixes #1850 Set event.redraw to true before passing it to event handlers, fixes #1850 Jul 5, 2017

@pygy pygy added this to the v1.1.2 milestone Jul 5, 2017

@pygy pygy force-pushed the pygy:fix-1850 branch from 1b7378c to 947447a Jul 6, 2017

@pygy

This comment has been minimized.

Copy link
Member

pygy commented Jul 6, 2017

Moved the reset to api/redraw.js where it belongs, and now we can write tests in api/tests/test-redraw.js.

@pygy pygy force-pushed the pygy:fix-1850 branch from 947447a to 67b11f1 Jul 6, 2017

@pygy pygy merged commit 4a00126 into MithrilJS:next Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment