New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Content-Type header bug (Issue #1919) #1924

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
4 participants
@tskillian
Copy link

tskillian commented Aug 1, 2017

Fixes #1919

@tskillian tskillian requested a review from lhorie as a code owner Aug 1, 2017

@tskillian tskillian force-pushed the tskillian:fixRequestContentHeaders branch from 91fff7c to 650c3fa Aug 1, 2017

@tskillian tskillian requested a review from tivac as a code owner Aug 1, 2017

@pygy

This comment has been minimized.

Copy link
Member

pygy commented Aug 2, 2017

@tskillian That's great, I see you've updated the mocks (the existing tests in request/tests/test-request.js were correct assuming proper mocks), it would be nice if you could add some mocks tests as well in test-utils/tests/test-xhrMock.js.

@tskillian tskillian force-pushed the tskillian:fixRequestContentHeaders branch from 650c3fa to b4856a9 Aug 3, 2017

@tskillian

This comment has been minimized.

Copy link

tskillian commented Aug 3, 2017

@pygy done

@pygy

This comment has been minimized.

Copy link
Member

pygy commented Aug 3, 2017

Beautiful, thanks :-)

@pygy pygy merged commit 2032131 into MithrilJS:next Aug 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment