New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting navigation options with m.route.link API #1930

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@orbitbot
Copy link
Contributor

orbitbot commented Aug 8, 2017

Description

Some refactoring to enable passing the options object to m.route.set using the m.route.link API in lifecycle methods.

Motivation and Context

With current functionality, there is no way to overwrite browser history entries and pass specific parameters to the history API with m.route.link, this always requires a custom method to be written.

Related issues #1807 #1810

How Has This Been Tested?

npm t with new test case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@orbitbot orbitbot requested review from lhorie and tivac as code owners Aug 8, 2017

@tivac

tivac approved these changes Aug 8, 2017

Copy link
Member

tivac left a comment

🎉

@orbitbot

This comment has been minimized.

Copy link
Contributor

orbitbot commented Oct 28, 2017

Anyone mind processing this? :)

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Oct 28, 2017

@orbitbot Add a changelog entry, and it'll be ready to merge.

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Oct 28, 2017

Apologies for this slipping through the cracks... 😟

@orbitbot

This comment has been minimized.

Copy link
Contributor

orbitbot commented Oct 29, 2017

@isiahmeadows What's the proper heading to put a new change-log.md entry under? Is there going to be a 1.1.6, or should I just chuck a line somewhere in the 2.0.0 WIP section?

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Oct 29, 2017

Just chuck it into the v2.0.0 section - it'll get moved if/once it's backported.

@orbitbot orbitbot force-pushed the orbitbot:m-link-options branch from c11a33f to 131e610 Oct 29, 2017

@orbitbot

This comment has been minimized.

Copy link
Contributor

orbitbot commented Oct 29, 2017

Updated the PR.

@isiahmeadows isiahmeadows merged commit 1a81c1c into MithrilJS:next Oct 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

isiahmeadows added a commit to isiahmeadows/mithril.js that referenced this pull request Oct 12, 2018

Merge pull request MithrilJS#1930 from orbitbot/m-link-options
Enable setting navigation options with m.route.link API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment