Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixing IE bug causing active element to be null causing render function to error #1943
There is an issue in IE where
When this happens using mithril, the render function throws an error on line 633.
This is an issue that has come up in other frameworks, for example in Angular.
Motivation and Context
In my case, I have a click event that removes an element that has an
How Has This Been Tested?
Confirmed this does not break any tests and does not cause any lint errors. I'm not sure what a new test would look like since
Types of changes
@JacksonJN thanks for the report/PR, are you sure that it is always
Also, updating the mocks for having
@pygy I am pretty sure it is only
if (active && $doc.activeElement !== active) active.focus()
Also I have added an inline comment about the bug.