Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
render: fix perf regression introduced by #1918 #2052
I wanted to make sure that the changes I'm making to updateNodes don't have a negative impact on benchmarks and noticed a stark perf regression in the
How Has This Been Tested?
as little as #1918 since the mocks still don't support the correct API.
Types of changes
We have a builtin
I used git bisect to identify the problem commit.
From the branch HEAD:
git bisect start git bisect bad # mark the current commit as bad git bisect good v1.1.5 # mark the last known good commit
At that point,
Mark -4 ad good:
Repeat until you've identified the first bad commit. Git bisect automatically moves the cursor for you.
I focused on the worse regression because running the benchmarks reliably requires me to exit every program and leave the computer alone. It turns out there are other problems.
I'm not faulting you here BTW @robinchew, your PR passed review. I didn't expect such a simple access to be that expensive.