Trust svg

[pygy]

Add support for SVG in m.trust() strings, and some DOMParser support in the mocks.

Description

This leverages the DOMParser API (IE 10+) to enable users to use m.trust() to create raw SVG fragments.

How Has This Been Tested?

I've added corresponding tests for render and the mocks.

The mocks test also pass in Firefox, Chrome, Safari IE11 and Edge (thanks to @Yatekii for the last two).

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation change

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated docs/change-log.md

[pygy]

I'll also add a SVG example in the docs

[barneycarroll]

Neat work, fantastic turnaround!

[pygy]

I'd like to rely on the same API for HTML, tough we'd probably have to adapt the possibleParent logic.

MathML can probably be done the same way, but I haven't tried.

[tivac]

This lgtm, but I know little enough about the underlying pieces that I'm not gonna approve the review. @isiahmeadows is probably a better choice.

[pygy]

@tivac I don't know much either.

I knew there was a client-side markup parser, and I learnt how to use it yesterday.

There may be corner cases that are not handled properly, similar to the possibleParent table for HTML. I don't actually know what would break if we always used a div as a container for setting the innerHTML...

As mentioned in Gitter, I've tried to abuse synchronous XHR with data:URI to parse SVG in IE9, but it is rejected (using XMLHttpRequest, XDomainRequest and ActiveXObject("MSXML2.XMLHTTP")) but the trick works in browsers that don't need it since they supprt DOMParser.

[dead-claudia]

LGTM.

[dead-claudia]

I appreciate pulling this out. (I almost did over half a dozen times, and just didn't.)

[pygy]

Actually, please don't merge this yet, it can be done without the DOMParser API after all:

temp.innerHTML = "<svg>" + value + "</svg>"; temp = temp.firstChild

I'll update this tomorrow evening.

[pygy]

Here we go, less code, and IE9 compat (for the 1 out of 500 people who still use it worldwide 🙄 )