New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting `responseType` of xhr via m.request options #2193

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@StephanHoyer
Copy link
Member

StephanHoyer commented Jul 20, 2018

Add support for response type to m.request

Description

Just that

Motivation and Context

might be handy

How Has This Been Tested?

wrote a test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@StephanHoyer StephanHoyer requested a review from tivac as a code owner Jul 20, 2018

@StephanHoyer StephanHoyer force-pushed the StephanHoyer:m-request-content-type branch from 6dbff5a to d06c1cb Jul 20, 2018

@StephanHoyer StephanHoyer changed the title Add support for setting `responseType` of xht via m.request options Add support for setting `responseType` of xhr via m.request options Jul 21, 2018

@pygy

This comment has been minimized.

Copy link
Member

pygy commented Aug 6, 2018

@StephanHoyer Thanks for the PR, LGTM!

This will be merged by the end of the week if no one objects.

@StephanHoyer

This comment has been minimized.

Copy link
Member

StephanHoyer commented Aug 20, 2018

ping :D

@pygy pygy merged commit af90b6b into MithrilJS:next Aug 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pygy

This comment has been minimized.

Copy link
Member

pygy commented Aug 20, 2018

Merged! Thanks @StephanHoyer!

@StephanHoyer StephanHoyer deleted the StephanHoyer:m-request-content-type branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment