New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update for unpkg src attr #2205

Merged
merged 3 commits into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@cavemansspa
Copy link
Contributor

cavemansspa commented Aug 21, 2018

No description provided.

cavemansspa added some commits Aug 21, 2018

@cavemansspa cavemansspa requested a review from tivac as a code owner Aug 21, 2018

@orbitbot

This comment has been minimized.

Copy link
Contributor

orbitbot commented Aug 21, 2018

AFAIK (without checking) this is intentional and should not require a change.

@orbitbot

This comment has been minimized.

Copy link
Contributor

orbitbot commented Aug 21, 2018

After checking, this works as intended as long as the file is being served through any development server, and not opened directly as a file. Perhaps rather update the documentation to state that.

@pygy pygy merged commit e62f0f3 into MithrilJS:next Aug 21, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@pygy

This comment has been minimized.

Copy link
Member

pygy commented Aug 21, 2018

Thanks @cavemansspa.

@orbitbot It doesn't hurt, if only to prevent man in the middle attacks while developing locally (stuff like bad public proxies/access points that inject code in unencrypted content).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment