Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rewrite stream #2207
So after a bit of fiddling trying to solve 2 issues related to mithril streams, I ended up trying to do an implementation from scratch just to get a better understanding of how it all hooked up.
After a bit of back and forth with @pygy on gitter I think I've ended up with a simpler implementation, which at the same time fixes the bugs mentioned above.
Another small benefit is that it is 1-3x faster depending on browser for simple tests using map and compose.
The first one that got merged actually behaves wrong in that it ends the stream completely (wrong fix)
There was also another issue fixed with regards to the changed streams returned in combine which required fixing a test.
At the same time I've also renamed HALT to SKIP, which feels a bit more correct relating to its function.
How Has This Been Tested?
Using all current stream tests, correcting 1 test, and adding another
Types of changes