Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundancy #2213

Merged
merged 9 commits into from Sep 19, 2018
Merged

Fix redundancy #2213

merged 9 commits into from Sep 19, 2018

Conversation

dead-claudia
Copy link
Member

Description

Motivation and Context

Fix a redundant return within initComponent - the method's return value is never used in the only caller.

How Has This Been Tested?

Ran the test suite just as a sanity check.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@dead-claudia
Copy link
Member Author

The history is a bit noisy, but it's been a while since I updated my local fork and sync'd it to here. I also switched remote names, because for some reason, I had two different remotes pointing here... 😕

@dead-claudia
Copy link
Member Author

@MithrilJS/collaborators Can I get a review for this real quick?

@dead-claudia
Copy link
Member Author

I'm self-merging, since it's pretty trivial and it shouldn't break anything.

@dead-claudia dead-claudia merged commit ad51181 into MithrilJS:next Sep 19, 2018
@dead-claudia dead-claudia deleted the fix-redundancy branch September 19, 2018 05:23
dead-claudia added a commit to dead-claudia/mithril.js that referenced this pull request Oct 12, 2018
* Remove redundant empty fragment return

* Rebuild bundles

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant