Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental back compat break for event optimization #2222

Merged
merged 4 commits into from Sep 18, 2018

Conversation

dead-claudia
Copy link
Member

@dead-claudia dead-claudia commented Sep 3, 2018

Description

Motivation and Context

See here for more details: #1949 (comment)

How Has This Been Tested?

Added a few new tests and ran them in Node.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

This was supposed to be purely additive. See here for more details:

MithrilJS#1949 (comment)
@dead-claudia
Copy link
Member Author

This was an oversight when developing/reviewing the initial patch.

FWIW, we never documented how event handlers were added, so I don't feel it's breaking to backport (unlike when I first wrote #1949).

@barneycarroll Could you take a quick look, in case I missed anything?

@dead-claudia dead-claudia requested review from barneycarroll and removed request for tivac and pygy September 3, 2018 12:24
@dead-claudia
Copy link
Member Author

@MithrilJS/collaborators Can I get a review for this real quick?

@StephanHoyer
Copy link
Member

lgtm.

@dead-claudia dead-claudia merged commit c703b03 into MithrilJS:next Sep 18, 2018
@dead-claudia dead-claudia deleted the fix-back-compat branch September 18, 2018 14:21
dead-claudia added a commit to dead-claudia/mithril.js that referenced this pull request Oct 12, 2018
…JS#2222)

This was supposed to be purely additive. See here for more details:

MithrilJS#1949 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants