Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid triggering Object.prototype.__proto__ with keys #2251

Merged
merged 1 commit into from Oct 15, 2018
Merged

Avoid triggering Object.prototype.__proto__ with keys #2251

merged 1 commit into from Oct 15, 2018

Conversation

dead-claudia
Copy link
Member

Description

This way, the diff algorithm works with untrusted keys.

Motivation and Context

How Has This Been Tested?

Added a new unit test for this subtle key bug.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@dead-claudia dead-claudia added the Type: Bug For bugs and any other unexpected breakage label Oct 14, 2018
@dead-claudia dead-claudia added this to the 2.0.0 milestone Oct 14, 2018
@dead-claudia
Copy link
Member Author

I'll backport this to v1.2 on a patch release after #2247 gets released.

@dead-claudia
Avoid triggering Object.prototype.__proto__ with keys
a972760 
This way, the diff algorithm works with untrusted keys.
@dead-claudia dead-claudia merged commit 88b17c1 into MithrilJS:next Oct 15, 2018
@dead-claudia dead-claudia deleted the map-fix branch October 15, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pygy pygy Awaiting requested review from pygy

Assignees
No one assigned
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dead-claudia