New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid triggering `Object.prototype.__proto__` with keys #2251

merged 1 commit into from Oct 15, 2018


None yet
1 participant
Copy link

isiahmeadows commented Oct 14, 2018


This way, the diff algorithm works with untrusted keys.

Motivation and Context

How Has This Been Tested?

Added a new unit test for this subtle key bug.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/

@isiahmeadows isiahmeadows requested a review from pygy as a code owner Oct 14, 2018

@isiahmeadows isiahmeadows added the bug label Oct 14, 2018

@isiahmeadows isiahmeadows added this to the 2.0.0 milestone Oct 14, 2018


This comment has been minimized.

Copy link

isiahmeadows commented Oct 14, 2018

I'll backport this to v1.2 on a patch release after #2247 gets released.

@isiahmeadows isiahmeadows force-pushed the isiahmeadows:map-fix branch from d12b559 to a972760 Oct 14, 2018

Avoid triggering `Object.prototype.__proto__` with keys
This way, the diff algorithm works with untrusted keys.

@isiahmeadows isiahmeadows merged commit 88b17c1 into MithrilJS:next Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@isiahmeadows isiahmeadows deleted the isiahmeadows:map-fix branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment