Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store normalized vnodes in the dom element. Add render tests. #2266

merged 2 commits into from Oct 28, 2018


Copy link

@spacejack spacejack commented Oct 28, 2018


Ensures that vnodes are normalized before being stored in the dom element (in m.render()).

Motivation and Context

Fixes #2264

How Has This Been Tested?

Existing tests pass, added tests to cover this case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/
@spacejack spacejack requested a review from pygy as a code owner Oct 28, 2018
Copy link

@isiahmeadows isiahmeadows left a comment

Just needs a changelog entry.

@isiahmeadows isiahmeadows merged commit ea0ce7f into MithrilJS:next Oct 28, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
@isiahmeadows isiahmeadows added this to Closed in Triage/bugs via automation Oct 28, 2018
@spacejack spacejack deleted the spacejack:store-normalized-vnodes branch Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants