Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Officially drop IE9-10 support, pull out our hacks #2296
Motivation and Context
Spurred by some recent Gitter discussion: https://gitter.im/mithriljs/mithril.js?at=5beb8483fee6703aaf68b18b
How Has This Been Tested?
N/A: the only functional code change wasn't specifically tested for anyways.
Types of changes
requested review from
and removed request for
Nov 14, 2018
I'm using mithril in a project that is used in IE9, does this mean that it will still work if I use some core-js polyfills or something?
Right now I'm using bluebird to polyfill Promises, and I believe I can polyfill rAF. Is there anything else to consider? (at least I don't have to care about load times. Performance doesn't matter for our IE clientele, they just need it to load at some point)
I can't kill it, unfortunately.
@ProtonScott Are you running this on Windows Server or Windows Embedded? If so, I'll consider looking into supporting IE9 (as it's still supported by Microsoft), but since Microsoft does not support IE9/10 for desktop, support for there is pretty much out of the equation.
Also, keep in mind v1 still supports it. v2 is what would break that support.
@isiahmeadows I know you closed this no bigs, but I just wanted to clarify:
I am not using it on Windows Server or Embedded. Its a legacy app that has to work with some state goverment agencies: there are a few (sub 2% of clients, but the state mandates that we have 100% support for all) that are on IE8 or 9. 95% of it is IE11 and a few percentage poitns is IE10, but we still ahve to support those until I believe late next year or Jan 1 2020, not that it matters.
I'm not worried. I'll just polyfill the best I can. If there is a persistent issue i'll just file tickets and such, its all suppose to get upgraded soon enough I believe. Just wanted to get some idea of scope :)
Thank you! Appreciate it. we'll do our best. I'm not worried about it, as much as I just want to prepare when the time comes (I hate splitting code bases where we have support for 1 set of things then another. I'd rather just polyfill, cause I'm a little lazy on that front, but if needed we could move old clients to v1.2 and move to 2.0 on our main) I should check usage logs again too, maybe its fallen again (I could have swore I saw IE10 once in our logs haha, not that it matters, but this is a good impedious for me to check those stats on my end, obviously) I don't expect you guys to have to change this or consider it.
I appreciate the quick responses.