New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style updates to avoid unnecessary allocation #2312

Merged
merged 5 commits into from Dec 3, 2018

Conversation

3 participants
@isiahmeadows
Copy link
Collaborator

isiahmeadows commented Nov 27, 2018

Description

Fix style updates to avoid an unnecessary intermediate object. I recast it locally and had the code ready prior to #2311, which should explain why it's a little less surgical.

  • Drive-by: properly censor cssFloat -> css float: to match DOM behavior

Motivation and Context

See this comment. This is a follow-up to #2311.

How Has This Been Tested?

Ran the usual and nothing broke. ☺️

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@project-bot project-bot bot added this to Needs triage in Triage/bugs Nov 27, 2018

@isiahmeadows isiahmeadows moved this from Needs triage to High priority in Triage/bugs Nov 27, 2018

@isiahmeadows isiahmeadows added the bug label Nov 27, 2018

@StephanHoyer
Copy link
Member

StephanHoyer left a comment

Two small nits, besides that, i'm fine

Show resolved Hide resolved render/render.js Outdated
Show resolved Hide resolved render/render.js

@isiahmeadows isiahmeadows force-pushed the isiahmeadows:fix-styles branch from 8d34b54 to 8c8e6db Nov 30, 2018

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Dec 1, 2018

@StephanHoyer These updates look good to you?

@isiahmeadows isiahmeadows force-pushed the isiahmeadows:fix-styles branch from 8c8e6db to b1b276e Dec 3, 2018

@isiahmeadows isiahmeadows merged commit 8134c51 into MithrilJS:next Dec 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Triage/bugs automation moved this from High priority to Closed Dec 3, 2018

@isiahmeadows isiahmeadows deleted the isiahmeadows:fix-styles branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment