New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variadic arguments to `m.fragment` #2328

Merged
merged 4 commits into from Dec 6, 2018

Conversation

2 participants
@isiahmeadows
Copy link
Collaborator

isiahmeadows commented Dec 4, 2018

Description

Basically, same idea as #2327, done almost at the same time. 馃槃

Motivation and Context

See #2327 - it includes a better writeup than this.

Edit: Fixes #2275.

Edit: Closes #2327.

How Has This Been Tested?

Added new tests, ran existing ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

isiahmeadows added some commits Dec 4, 2018

Implement support for variadic arguments to `m.fragment`
While I was at it, I refactored the common logic out of `hyperscript`.

@project-bot project-bot bot added this to Needs triage in Triage/bugs Dec 4, 2018

@@ -1,5 +1,7 @@
* text=auto
/mithril.js binary
/mithril.min.js binary
/mithril.mjs binary

This comment has been minimized.

@isiahmeadows

isiahmeadows Dec 4, 2018

Collaborator

This slip-in change was because #2325 missed it, and I forgot to add it in as part of the review.

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Dec 4, 2018

@barneycarroll You beat me by like 15 seconds... 馃槃

@isiahmeadows isiahmeadows requested a review from barneycarroll Dec 4, 2018

@barneycarroll
Copy link
Member

barneycarroll left a comment

I like this more than mine.

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Dec 6, 2018

@barneycarroll I incorporated your docs changes.

@isiahmeadows isiahmeadows requested a review from barneycarroll Dec 6, 2018

@barneycarroll barneycarroll referenced this pull request Dec 6, 2018

Closed

Normalise fragments #2327

8 of 8 tasks complete
@barneycarroll
Copy link
Member

barneycarroll left a comment

Great stuff

Explain rationale for `hyperscriptVnode`'s calling convention
This way, it doesn't get erroneously "cleaned up" into something worse,
and so it's clearer how it'd be potentially optimized once ES5 support
is dropped.

@isiahmeadows isiahmeadows merged commit 966e78b into MithrilJS:next Dec 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Triage/bugs automation moved this from Needs triage to Closed Dec 6, 2018

@isiahmeadows isiahmeadows deleted the isiahmeadows:fragment branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment