Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variadic arguments to m.fragment #2328

Merged
merged 4 commits into from Dec 6, 2018

Conversation

dead-claudia
Copy link
Member

@dead-claudia dead-claudia commented Dec 4, 2018

Description

Basically, same idea as #2327, done almost at the same time. 馃槃

Motivation and Context

See #2327 - it includes a better writeup than this.

Edit: Fixes #2275.

Edit: Closes #2327.

How Has This Been Tested?

Added new tests, ran existing ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@project-bot project-bot bot added this to Needs triage in Triage/bugs Dec 4, 2018
@@ -1,5 +1,7 @@
* text=auto
/mithril.js binary
/mithril.min.js binary
/mithril.mjs binary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slip-in change was because #2325 missed it, and I forgot to add it in as part of the review.

@dead-claudia
Copy link
Member Author

@barneycarroll You beat me by like 15 seconds... 馃槃

Copy link
Member

@barneycarroll barneycarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this more than mine.

@dead-claudia
Copy link
Member Author

@barneycarroll I incorporated your docs changes.

@barneycarroll barneycarroll mentioned this pull request Dec 6, 2018
8 tasks
Copy link
Member

@barneycarroll barneycarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

This way, it doesn't get erroneously "cleaned up" into something worse,
and so it's clearer how it'd be potentially optimized once ES5 support
is dropped.
@dead-claudia dead-claudia merged commit 966e78b into MithrilJS:next Dec 6, 2018
Triage/bugs automation moved this from Needs triage to Closed Dec 6, 2018
@dead-claudia dead-claudia deleted the fragment branch December 6, 2018 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Make m.fragment shadow m's signature overloading logic
2 participants