Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Streamline route/request path handling and split params + body in requests #2361
See the commit message for what all this entails. Here's a quick summary:
Edit: update to include latest stuff.
Motivation and Context
See the commit message after the horizontal line for the context and reasoning behind it.
How Has This Been Tested?
Ran all the existing tests, added new tests where necessary, and changed a few existing tests. The changed tests are almost exclusively around
Types of changes
StephanHoyer left a comment
Added one additional test for conflicting
Besides that, nice work!
Updated the title to clarify this isn't ready yet. Please don't merge this yet. I'll request new reviews once I'm ready.
I also requested reviews from both of you since it's a pretty significant overhaul, and it's really a part 2 of simplifying the v2 internals outside
My other planned changes, all non-breaking and slated for future PRs, are:
Everything else I'd like to do that's breaking I'm punting to v3.
@barneycarroll Let me clarify:
Feb 2, 2019
changed the title
WIP: Streamline route/request path handling and split params + body in requests
Feb 2, 2019
Okay, this is ready for review and should be close to merge quality. I know it's a relatively large PR, but most of the diff is just adding tests and docs where there was nothing previously.
In case you're curious, the path names were briefly documented in
I know the jump of 400 bytes is a little unsettling, but I feel I could probably regain most, if not all, of that by simply combining