Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2419 #2421

Merged
merged 2 commits into from May 31, 2019

Conversation

@isiahmeadows
Copy link
Collaborator

commented May 31, 2019

Description

Unbreak request bodies without content.

If you do need to pass content, this will provide JSON as the default encoding, and you'll still need to address CORS, but you can still generally send things as plain text.

Motivation and Context

Fixes #2419.

How Has This Been Tested?

Ran tests and added a few new ones to ensure this doesn't break again.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@project-bot project-bot bot added this to Needs triage in Triage/bugs May 31, 2019

@isiahmeadows isiahmeadows merged commit 0ce3aa0 into MithrilJS:next May 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Triage/bugs automation moved this from Needs triage to Closed May 31, 2019

@isiahmeadows isiahmeadows deleted the isiahmeadows:fix-request branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.