Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track XHR replacements correctly #2455

Merged
merged 2 commits into from Jul 5, 2019
Merged

Track XHR replacements correctly #2455

merged 2 commits into from Jul 5, 2019

Conversation

dead-claudia
Copy link
Member

@dead-claudia dead-claudia commented Jul 5, 2019 •
edited

Description

Motivation and Context

Fixes #2439

How Has This Been Tested?

New tests, updated existing ones

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@project-bot project-bot bot added this to Needs triage in Triage/bugs Jul 5, 2019
@dead-claudia dead-claudia merged commit 8eed896 into MithrilJS:next Jul 5, 2019
Triage/bugs automation moved this from Needs triage to Closed Jul 5, 2019
@dead-claudia dead-claudia deleted the update-request branch July 5, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Triage/bugs
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config in m.request should be able to directly call into the onreadystatechange logic
1 participant
@dead-claudia