Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop m.version #2466

Merged
merged 2 commits into from Jul 10, 2019
Merged

Drop m.version #2466

merged 2 commits into from Jul 10, 2019

Conversation

@isiahmeadows
Copy link
Member

@isiahmeadows isiahmeadows commented Jul 10, 2019

Description

Motivation and Context

It's caused way too much grief over the years, and I've finally decided it's worth pitching. For those who need it, it's easy to get, especially if you use it through Node or a build system. And for those who are just loading it globally, you have to explicitly specify the version anyways, so you'd be just as golden if you followed it up with a simple inline script that does m.version = "the version you loaded".

Oh, and also, you shouldn't be coding specifically for version numbers, either - it's a known anti-pattern. Instead, you should prefer feature detection and just do the right thing.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. (N/A - I'm removing a feature)
  • All new and existing tests passed.
  • I have updated docs/change-log.md
It's caused way too much grief over the years, and I've finally decided
it's worth pitching. For those who need it, it's easy to get, especially
if you use it through Node or a build system. And for those who are just
loading it globally, you have to explicitly specify the version anyways,
so you'd be just as golden if you followed it up with a simple inline
script that does `m.version = "the version you loaded"`.

Oh, and also, you shouldn't be coding specifically for version numbers,
either - it's a known anti-pattern. Instead, you should prefer feature
detection and just do the right thing.
@project-bot project-bot bot added this to Needs triage in Triage/bugs Jul 10, 2019
@isiahmeadows isiahmeadows merged commit 904b63b into MithrilJS:next Jul 10, 2019
Triage/bugs automation moved this from Needs triage to Closed Jul 10, 2019
@isiahmeadows isiahmeadows deleted the remove-version branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant